Add clang-tidy reviews to CI#1407
Merged
slaren merged 1 commit intoggml-org:masterfrom May 12, 2023
Merged
Conversation
ggerganov
approved these changes
May 11, 2023
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Should already have the write permission:
Collaborator
|
I wanted to ask if it uses clang-tidy-diff, but the change suggestions look fine too. |
Member
Author
|
It doesn't use clang-tidy-diff, but essentially it does the same, it checks what lines were modified and passes a |
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
* Update server string/regex ban documentation * Update README.md * Update README.md
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds clang-tidy static analyzer and linter checks to pull requests.
The failed checks are reported in the PR in a comment, see these for some examples:
slaren#11
slaren#12 (here it finds a bug in the command line parsing of
benchmark-matmult.cpp)I tried to remove some of the most pedantic checks, but there are still a lot of failed checks in the current code that should be addressed over time. However, the workflow action will only report the checks failed in the lines modified by the PR, so the current issues will not be blamed on new PRs (unless they happen to be in the lines modified by the PR).
To test the settings in
.clang-tidylocally:-DCMAKE_EXPORT_COMPILE_COMMANDS=on-pand the source file, for example:clang-tidy -p build llama.cppNote that since this adds comments to the PRs, it requires adding write permissions to the workflows in the project settings.