sycl: Hotfix for non dnnl codepath#14677
Merged
Alcpz merged 1 commit intoggml-org:masterfrom Jul 14, 2025
Merged
Conversation
Alcpz
approved these changes
Jul 14, 2025
Collaborator
Alcpz
left a comment
Alcpz
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. I don't mind the split codepath since we aim to remove MKL in the future.
github-actions
Bot
added
ggml
ShanoToni
force-pushed
the
sycl_batched_mul_mat_fix
branch
from
942a18d to
b93e848
Compare
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #14617 introduced new logic for dnnl codepath for batched mulmats to improve broadcast logic and support strided data. Due to this the use of
get_to_fp16_nc_syclwhich has overhead compared toget_to_fp16_sycl.The non DNNL codepath however still does not support non continuous
src1without thenc_syclfunction which caused failures when not running DNNL.This PR ensures correct behaviour.