vulkan/cuda: Fix im2col when KW!=KH#14789
Merged
0cc4m merged 1 commit intoggml-org:masterfrom Jul 21, 2025
Merged
Conversation
The tid is decomposed into "ow + ky*OW + kx*OW*KH". Change "ksize" to match.
github-actions
Bot
added
testing
Contributor
Author
|
CC @etasnadi |
0cc4m
approved these changes
Jul 21, 2025
Contributor
0cc4m
left a comment
0cc4m
left a comment
There was a problem hiding this comment.
I can confirm that this fixes the issue on Vulkan and CUDA.
JohannesGaessler
approved these changes
Jul 21, 2025
Merged
This was referenced Jul 21, 2025
taronaeo
pushed a commit
to taronaeo/llama.cpp-s390x
that referenced
this pull request
Jul 25, 2025
The tid is decomposed into "ow + ky*OW + kx*OW*KH". Change "ksize" to match.
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
The tid is decomposed into "ow + ky*OW + kx*OW*KH". Change "ksize" to match.
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
The tid is decomposed into "ow + ky*OW + kx*OW*KH". Change "ksize" to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tid is decomposed into
ow + ky*OW + kx*OW*KH. Changeksizeto match.Fixes #14777.