opencl: add fused rms_norm_mul#14841
Merged
rmatif merged 2 commits intoggml-org:masterfrom Jul 25, 2025
Merged
Conversation
Member
|
LGTM, but I can't test. |
Collaborator
|
Thank you! I was thinking about adding this one LGTM. Results on Adreno 830:
|
rmatif
approved these changes
Jul 25, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* opencl: add fused `rms_norm` + `mul` * opencl: improve workgroup size for `rms_norm_mul`
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* opencl: add fused `rms_norm` + `mul` * opencl: improve workgroup size for `rms_norm_mul`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fused
rms_norm_mulfollowing the pattern in #14800.Qwen2.5-1.5B on Adreno 750
with fusion
without fusion
Qwen2.5-3B on Adreno 750
with fusion
without fusion