Skip to content

Support intern-s1#14875

Merged
ngxson merged 6 commits intoggml-org:masterfrom
RunningLeon:support-interns1
Aug 7, 2025
Merged

Support intern-s1#14875
ngxson merged 6 commits intoggml-org:masterfrom
RunningLeon:support-interns1

Conversation

@RunningLeon
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the python python script changes label Jul 25, 2025
Comment thread convert_hf_to_gguf.py Outdated
Comment thread convert_hf_to_gguf.py Outdated
Comment thread convert_hf_to_gguf.py Outdated
Comment thread convert_hf_to_gguf.py Outdated
Comment thread convert_hf_to_gguf.py
Comment thread convert_hf_to_gguf.py Outdated
@CISC
Copy link
Copy Markdown
Member

CISC commented Jul 29, 2025

The Python Type-Check CI needs to be resolved.

@RunningLeon
Copy link
Copy Markdown
Contributor Author

The Python Type-Check CI needs to be resolved.

@CISC hi, could you tell how to fix this error? Seems not reasonable to me

/home/runner/work/llama.cpp/llama.cpp/convert_hf_to_gguf.py:3219:23 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
Error: Object of type "None" is not subscriptable (reportOptionalSubscript)
/home/runner/work/llama.cpp/llama.cpp/convert_hf_to_gguf.py:3220:13 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
Error: Object of type "None" is not subscriptable (reportOptionalSubscript)
/home/runner/work/llama.cpp/llama.cpp/convert_hf_to_gguf.py:3220:49 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
Error: Object of type "None" is not subscriptable (reportOptionalSubscript)
/home/runner/work/llama.cpp/llama.cpp/convert_hf_to_gguf.py:32[21](https://github.com/ggml-org/llama.cpp/actions/runs/16612224904/job/46997396567?pr=14875#step:5:22):23 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
Error: Object of type "None" is not subscriptable (reportOptionalSubscript)
/home/runner/work/llama.cpp/llama.cpp/convert_hf_to_gguf.py:3[22](https://github.com/ggml-org/llama.cpp/actions/runs/16612224904/job/46997396567?pr=14875#step:5:23)2:13 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
Error: Object of type "None" is not subscriptable (reportOptionalSubscript)
/home/runner/work/llama.cpp/llama.cpp/convert_hf_to_gguf.py:3222:49 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
Error: Object of type "None" is not subscriptable (reportOptionalSubscript)
6 errors, 0 warnings, 14 informations
Error: 6 errors

@CISC
Copy link
Copy Markdown
Member

CISC commented Jul 30, 2025

The Python Type-Check CI needs to be resolved.

@CISC hi, could you tell how to fix this error? Seems not reasonable to me

Running pyright locally helps, the line numbers are wrong for some reason, this is the actual erroneous codeblock:

if isinstance(self.hparams_vision['image_size'], list):
self.hparams_vision['image_size'] = self.hparams_vision['image_size'][0]
if isinstance(self.hparams_vision['patch_size'], list):
self.hparams_vision['patch_size'] = self.hparams_vision['patch_size'][0]

Comment thread convert_hf_to_gguf.py
Comment thread convert_hf_to_gguf.py
Comment thread gguf-py/gguf/tensor_mapping.py Outdated
Comment thread convert_hf_to_gguf.py Outdated
Comment thread convert_hf_to_gguf.py
Comment thread convert_hf_to_gguf.py
@CISC
Copy link
Copy Markdown
Member

CISC commented Aug 7, 2025

Can merge after changes and @ngxson approves.

@ngxson ngxson merged commit 99acbc9 into ggml-org:master Aug 7, 2025
6 checks passed
@CISC
Copy link
Copy Markdown
Member

CISC commented Aug 7, 2025

Hmmm, after changes... :)

@ngxson
Copy link
Copy Markdown
Contributor

ngxson commented Aug 7, 2025

woops sorry I missed that part. I guest @RunningLeon you need to open a new PR then

@RunningLeon
Copy link
Copy Markdown
Contributor Author

@

woops sorry I missed that part. I guest @RunningLeon you need to open a new PR then

ok, seems that only need to do the code format

@CISC CISC mentioned this pull request Aug 19, 2025
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
* support internvl

* support interns1

* resolve comments

* put interns1 in tensor mapping

* resolve comment

* move tokenizer changes to sub class
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* support internvl

* support interns1

* resolve comments

* put interns1 in tensor mapping

* resolve comment

* move tokenizer changes to sub class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants