ggml: WebGPU disable SET_ROWS for now#15078
Conversation
…building/submission
github-actions
Bot
added
the
devops
|
Looks like it is still failing. |
github-actions
Bot
added
the
ggml
|
Sorry this CI failure for WebGPU on the Linux machine is turning out to be trickier than I expected. I haven't been able to reproduce it locally yet, only on the Github action runners using the simulated Vulkan LLVMpipe backend. I'll keep working on it this week, to see if I can get a definitive answer into what's going on. In the meantime, would it make sense to just disable the WebGPU CI so it doesn't clutter up other PRs? |
|
Looks like the CI is passing now, I was able to debug on the Github action runner using this: https://github.com/mxschmitt/action-tmate. I believe the issue was due to not blocking on I also made another minor changes in this PR, to explicitly wait on A few of the macOS CI tests are still queued, I'll wait for them to complete successfully before merging. Hopefully the WebGPU CI is more stable from here on! |
* Add paramater buffer pool, batching of submissions, refactor command building/submission * Add header for linux builds * Free staged parameter buffers at once * Format with clang-format * Fix thread-safe implementation * Use device implicit synchronization * Update workflow to use custom release * Remove testing branch workflow * Disable set_rows until it's implemented * Fix potential issue around empty queue submission * Try synchronous submission * Try waiting on all futures explicitly * Add debug * Add more debug messages * Work on getting ssh access for debugging * Debug on failure * Disable other tests * Remove extra if * Try more locking * maybe passes? * test * Some cleanups * Restore build file * Remove extra testing branch ci
* Add paramater buffer pool, batching of submissions, refactor command building/submission * Add header for linux builds * Free staged parameter buffers at once * Format with clang-format * Fix thread-safe implementation * Use device implicit synchronization * Update workflow to use custom release * Remove testing branch workflow * Disable set_rows until it's implemented * Fix potential issue around empty queue submission * Try synchronous submission * Try waiting on all futures explicitly * Add debug * Add more debug messages * Work on getting ssh access for debugging * Debug on failure * Disable other tests * Remove extra if * Try more locking * maybe passes? * test * Some cleanups * Restore build file * Remove extra testing branch ci
3 participants
test-thread-safety was recently updated to use SET_ROWS by default, but the WebGPU backend doesn't support it yet. I'm aiming to add support and open a PR in the next couple days, but in the meantime disabling SET_ROWS for the CI so the WebGPU tests pass.