CUDA: add attention sinks for tile and wmma#15178
Merged
am17an merged 2 commits intoggml-org:masterfrom Aug 9, 2025
Merged
Conversation
Contributor
JohannesGaessler
left a comment
There was a problem hiding this comment.
This PR should produce correct results, but I think some of the synchronizations can be optimized out. In addition to the usual tests for correctness, please also check compute-sanitizer --tool=racecheck ./tests/test-backend-ops -o FLASH_ATTN_EXT, the compute sanitizer should come with the CUDA installation but it may not be on the PATH (on my system it's under /opt/cuda/bin/compute-sanitizer).
…rp_reduce_max from wmma
Contributor
Author
|
@JohannesGaessler the |
JohannesGaessler
approved these changes
Aug 9, 2025
Collaborator
|
If possible i would like to be tagged for prs that touch the wmma code. |
Thireus
added a commit
to Thireus/ik_llama.cpp
that referenced
this pull request
Aug 11, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Oct 6, 2025
This reverts commit 34c9d76.
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* CUDA: add attention sinks for tile and wmma * Review: formatting changes + remove syncthreads from tile + remove warp_reduce_max from wmma
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* CUDA: add attention sinks for tile and wmma * Review: formatting changes + remove syncthreads from tile + remove warp_reduce_max from wmma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding attention sink support for older GPUs (Volta and below), this would complete support for attention sinks in the flash attention code
on P100
master
PR
on V100
master (with fix) - at the moment it looks this model is broken on solely Volta because it goes through the wmma path even though attention sinks are not supported
PR