ci: Download SDKs in ios-xcode-build #15329
Closed
x0wllaar wants to merge 2 commits intoggml-org:masterfrom
Closed
ci: Download SDKs in ios-xcode-build #15329x0wllaar wants to merge 2 commits intoggml-org:masterfrom
x0wllaar wants to merge 2 commits intoggml-org:masterfrom
Conversation
Member
|
It looks like switching to |
Author
Member
|
@x0wllaar The real issue is that the default xcode is not the latest stable version (this seems like something that should/will be fixed), and that they no longer include SDKs for older xcode versions in the runner images. Thus, downloading the SDKs is not necessary, esp. as there's no reason for us to lock the builds down to older xcode versions. |
github-actions
Bot
added
the
devops
Author
|
Sure, #15324 is the better fix than, I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #15322 without affecting the XCode version and without the use of external actions, see actions/runner-images#12541
@slaren Feel free to close this in favor of: #15324