vulkan: workaround MoltenVK compile failure in multi_add#15506
Merged
0cc4m merged 2 commits intoggml-org:masterfrom Aug 24, 2025
Merged
vulkan: workaround MoltenVK compile failure in multi_add#155060cc4m merged 2 commits intoggml-org:masterfrom
0cc4m merged 2 commits intoggml-org:masterfrom
Conversation
github-actions
Bot
added
Vulkan
0cc4m
reviewed
Aug 23, 2025
Co-authored-by: Ruben Ortlam <picard12@live.de>
0cc4m
approved these changes
Aug 24, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* vulkan: workaround MoltenVK compile failure in multi_add * Update ggml/src/ggml-vulkan/vulkan-shaders/multi_add.comp Co-authored-by: 0cc4m <picard12@live.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15498. Fixes #15497.
Remove the readonly/writeonly qualifiers. I did some perf testing and don't see any negative effect on NVIDIA.