vulkan: fix min subgroup 16 condition for mmid subgroup optimization#15565
Merged
vulkan: fix min subgroup 16 condition for mmid subgroup optimization#15565
Conversation
jeffbolznv
approved these changes
Aug 25, 2025
|
Yes that works, thank you! :) This is a fantastic win because with flash attention the ROCm backend is now only better than Vulkan at small pp sizes where the difference doesn't really matter, and ROCm performance degrades very quickly as pp size increases. Vulkan
ROCm
|
Minh141120
pushed a commit
to janhq/llama.cpp
that referenced
this pull request
Aug 26, 2025
Minh141120
pushed a commit
to janhq/llama.cpp
that referenced
this pull request
Aug 27, 2025
rasbid
pushed a commit
to rasbid/llama.cpp
that referenced
this pull request
Oct 11, 2025
- Make subgroup_min_size_16 condition less restrictive for GCN (subgroup_max_size >= 8) - Add GCN-specific pipeline configurations with 64 subgroup sizes - Enable more aggressive subgroup usage for GCN architecture - Target: orders of magnitude performance improvement like PR ggml-org#15565
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the selection of the subgroup mmid optimization introduced in #15524.
@MrLavender please give it a try, it should be working for you with this fix.