vulkan: Use larger loads in scalar/coopmat1 matmul#15729
Merged
0cc4m merged 1 commit intoggml-org:masterfrom Sep 7, 2025
Merged
vulkan: Use larger loads in scalar/coopmat1 matmul#157290cc4m merged 1 commit intoggml-org:masterfrom
0cc4m merged 1 commit intoggml-org:masterfrom
Conversation
I think glslang will translate an access like x[i][1].z to OpAccessChain ... x, i, 1, 2 OpLoad float16_t ... rather than loading all of x[i] in a single OpLoad. Change the code to explicitly load the vector/matrix.
Contributor
|
That was one of the things I did in #12515, but never finished. I should get back to cleaning up the mul_mm.comp file. |
Contributor
This only seems to work for Nvidia. |
0cc4m
approved these changes
Sep 7, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
I think glslang will translate an access like x[i][1].z to OpAccessChain ... x, i, 1, 2 OpLoad float16_t ... rather than loading all of x[i] in a single OpLoad. Change the code to explicitly load the vector/matrix.
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
I think glslang will translate an access like x[i][1].z to OpAccessChain ... x, i, 1, 2 OpLoad float16_t ... rather than loading all of x[i] in a single OpLoad. Change the code to explicitly load the vector/matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think glslang will translate an access like x[i][1].z to
rather than loading all of x[i] in a single OpLoad. Change the code to explicitly load the vector/matrix.
Perf on 4070 using coopmat1: