vulkan: automatically remove unsupported devices#15976
Merged
0cc4m merged 4 commits intoggml-org:masterfrom Sep 17, 2025
netrunnereve:vulkan_unsupported
Merged
vulkan: automatically remove unsupported devices#159760cc4m merged 4 commits intoggml-org:masterfrom netrunnereve:vulkan_unsupported
0cc4m merged 4 commits intoggml-org:masterfrom
netrunnereve:vulkan_unsupported
Conversation
0cc4m
reviewed
Sep 14, 2025
Contributor
0cc4m
left a comment
There was a problem hiding this comment.
Thank you for the fix, but I would prefer it during the device selection, instead of removing devices afterwards. I can also do the implementation if you prefer that.
Collaborator
Author
|
Ok this should do it. I got rid of the warning message as well as I don't really see the point of that here. |
0cc4m
reviewed
Sep 16, 2025
Contributor
0cc4m
left a comment
There was a problem hiding this comment.
Looks good otherwise. I don't have a device to test this.
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* remove unsupported vulkan devices * make this happen during selection instead * pass by reference
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* remove unsupported vulkan devices * make this happen during selection instead * pass by reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically gets rid of any unsupported devices early on to avoid a crash as my Intel integrated chip with no 16 bit storage got enabled by #15947.
Before:
After: