ggml: add FLOOR unary op (CPU + SYCL)#15989
Closed
safranowith wants to merge 3 commits intoggml-org:masterfrom
Closed
ggml: add FLOOR unary op (CPU + SYCL)#15989safranowith wants to merge 3 commits intoggml-org:masterfrom
safranowith wants to merge 3 commits intoggml-org:masterfrom
Conversation
Implemented CPU + SYCL backends
Contributor
Author
|
// FLOOR: rounds each element down to the nearest integer. |
Contributor
|
I don't see the changes to test-backend-ops. |
Contributor
Author
|
Tests have been added to the test-backend-ops file. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the
FLOORunary operator to ggml, with implementations for both CPU and SYCL backends.Details
GGML_UNARY_OP_FLOORtoggml_unary_openum and updated operator name table.unary-ops.impl.h.element_wise.cppand dispatch inggml-sycl.cpp.ggml_backend_sycl_device_supports_opto allowFLOOR.Testing
-DGGML_SYCL=ON -DLLAMA_BUILD_TESTS=ON.ctest --output-on-failure: all relevant unary tests passed on CPU and SYCL (f32).FLOORoutputs vs. CPU reference implementation.Notes
f16support on SYCL GPUs may depend on driver/device capabilities (currently not supported on some Intel GPUs).f32works as expected across backends.