SYCL: Add COUNT_EQUAL operator support#15991
Merged
slaren merged 5 commits intoggml-org:masterfrom Sep 15, 2025
Merged
Conversation
github-actions
Bot
added
documentation
Contributor
NeoZhangJianyu
left a comment
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
- could you rebase the code since sycl_parallel_for() is reverted to stream->parallel_for() in base?
- same commit of #15937.
Thank you!
yael-works
force-pushed
the
yael/count-equal
branch
from
d401537 to
337d9f8
Compare
yael-works
force-pushed
the
yael/count-equal
branch
from
3031181 to
b39cc2d
Compare
|
|
||
| return a - b; | ||
|
|
||
| static __dpct_inline__ float op_count_equal(const float a, const float b) { |
Contributor
There was a problem hiding this comment.
please remove duplicated code in this file.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
I removed the duplicated op_count_equal definition from binbcast.hpp as requested.
The branch is now rebased on the latest master and clean.
NeoZhangJianyu
approved these changes
Sep 15, 2025
Contributor
NeoZhangJianyu
left a comment
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
Thank you for great work!
slaren
requested changes
Sep 15, 2025
yael-works
force-pushed
the
yael/count-equal
branch
from
3b29473 to
163b949
Compare
slaren
reviewed
Sep 15, 2025
yael-works
force-pushed
the
yael/count-equal
branch
from
d3b3536 to
0f6b7fd
Compare
yael-works
force-pushed
the
yael/count-equal
branch
from
0f6b7fd to
b427efb
Compare
slaren
approved these changes
Sep 15, 2025
Contributor
Author
|
The iOS CI job is failing due to a missing SDK on the runner (iOS 26.0 is not installed), which seems unrelated to this PR. |
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* SYCL: Add COUNT_EQUAL operator support (rebased on master) * SYCL: remove duplicate op_count_equal definition * tests: remove test_count_equal_typed and use test_count_equal for all cases * tests: keep only I32 case for COUNT_EQUAL as suggested * tests: keep only I32 case for COUNT_EQUAL as requested
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* SYCL: Add COUNT_EQUAL operator support (rebased on master) * SYCL: remove duplicate op_count_equal definition * tests: remove test_count_equal_typed and use test_count_equal for all cases * tests: keep only I32 case for COUNT_EQUAL as suggested * tests: keep only I32 case for COUNT_EQUAL as requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds GGML_OP_COUNT_EQUAL support to the SYCL backend.
Changes
ggml_sycl_op_count_equal()and its wrapperggml_sycl_count_equal()GGML_OP_COUNT_EQUALin:ggml_sycl_compute_forward()ggml_backend_sycl_device_supports_op()docs/ops.mdand regenerateddocs/ops/SYCL.csvto reflect SYCL supportF32,F16,I32, andI16Verification
cmake+make