SYCL/SET: Implement and document full support for SET operator#16006
SYCL/SET: Implement and document full support for SET operator#16006GittyBurstein wants to merge 3 commits intoggml-org:masterfrom
Conversation
1332bcf to
e654008
Compare
|
Hi, I’ve completed the implementation of the SET operator with SYCL support. |
|
@ggerganov @ggerganov/ggml-maintainers |
|
See #16032 (review) |
|
@ggerganov @ggerganov/ggml-maintainers |
|
@NeoZhangJianyu Could you please confirm if this approach is correct, or if you’d prefer me to restructure it differently? |
|
@ggerganov @ggml-org/ggml-maintainers @NeoZhangJianyu Hi! I would really appreciate it if you could review my code and guide me on the next steps. |
|
I refactored the SET operator implementation:
@NeoZhangJianyu – please review this change from the SYCL side |
|
@GittyBurstein Please stop spamming - this is not going to make things faster. |
This PR adds full SYCL support for the
SEToperator in llama.cpp, ensures test coverage on f32/i32 tensors, and updates documentation to show ✅ for SYCL indocs/ops.md.🔍 Summary of Work
Documentation updates
docs/ops/SYCL.csventries forSET.support=1anderror_message="yes".docs/ops.md→ nowSETshows ✅ under SYCL.Operator implementation (element_wise.cpp)
ggml_sycl_op_set:dst = src0(fast memcpy where possible).src1ontodstwith correctoffset,nb1,nb2,nb3.f32andi32.SYCL backend support (ggml-sycl.cpp)
GGML_OP_SETforGGML_TYPE_I32inggml_backend_sycl_device_supports_op.Testing
🛠️ Key Fixes and Lessons
offsetand strides (nb*) was crucial.📂 Helpful Commands (Developer Reference)