llama-quant : fix the verification of attention layers for encoder-decoder models#16023
Merged
CISC merged 1 commit intoggml-org:masterfrom Sep 17, 2025
Merged
llama-quant : fix the verification of attention layers for encoder-decoder models#16023CISC merged 1 commit intoggml-org:masterfrom
CISC merged 1 commit intoggml-org:masterfrom
Conversation
…coder models Signed-off-by: Jie Fu <jiefu@tencent.com>
CISC
reviewed
Sep 16, 2025
Contributor
Author
CISC
approved these changes
Sep 17, 2025
Contributor
Author
|
Thanks @CISC . |
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
…coder models (#16023) Signed-off-by: Jie Fu <jiefu@tencent.com>
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…coder models (ggml-org#16023) Signed-off-by: Jie Fu <jiefu@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llama.cpp fails to quantize T5 models with unequal encoder-decoder blocks.
The failure was caused by the failing of the verification of attention layers.
GGML_ASSERT((qs.n_attention_wv == n_attn_layer - pruned_attention_w) && "n_attention_wv is unexpected");The original verification has assumed that the encoder and decoder have the same number of blocks.
So it fails with unequal encoder-decoder models.
Testing: flan-t5-small, t5-small and an unequal encoder-decoder t5 model