ggml : refactor forward_dup for cpu backend#16062
Merged
ngxson merged 4 commits intoggml-org:masterfrom Sep 19, 2025
Merged
Conversation
ggml : refactor forward_dup for cpu backend
ggerganov
approved these changes
Sep 18, 2025
Contributor
Author
|
I did a pref test between master & PR. While the result fluctuate quite a lot from one run to another, I can see that the peak performance stays the same: |
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Oct 23, 2025
* ggml : refactor forward_dup for cpu backend * clean up a bit * add quant/dequant perf test
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* ggml : refactor forward_dup for cpu backend * clean up a bit * add quant/dequant perf test
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* ggml : refactor forward_dup for cpu backend * clean up a bit * add quant/dequant perf test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref discussion: #15783 (comment)
Refactor this code by using cpp template function
I tested this code by running
test-backend-opsagainst CPU <--> Metal/CUDA/Vulkan, but maybe there are some cases missed from the test. Would be nice if you can have a deeper look, thanks!