Adding git in container package dependencies#1621
Merged
DannyDaemonic merged 1 commit intoggml-org:masterfrom May 29, 2023
Merged
Adding git in container package dependencies#1621DannyDaemonic merged 1 commit intoggml-org:masterfrom
DannyDaemonic merged 1 commit intoggml-org:masterfrom
Conversation
The build-info.sh script is invoking git on lines 6 and 11. However git is not installed by default in ubuntu base images. This causes an unhandled exception to occur, which is silently passed during the build. Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
Contributor
|
Good catch. Can you confirm this changes the output from main from |
Contributor
Author
Certainly. The original build info from the container: and the one I get from container with this patch: |
DannyDaemonic
approved these changes
May 28, 2023
wbruna
pushed a commit
to wbruna/llama.cpp
that referenced
this pull request
Jul 2, 2025
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
Git added to build packages for version information in docker image Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
Git added to build packages for version information in docker image Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
Git added to build packages for version information in docker image Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build-info.sh script is invoking git on lines 6 and 11. However git is not installed by default in ubuntu base images.
This causes an unhandled exception to occur, which is silently passed during the build.
#1626
For example:
https://github.com/ggerganov/llama.cpp/actions/runs/5100538614/jobs/9168878817#step:6:1266
https://github.com/ggerganov/llama.cpp/actions/runs/5100538614/jobs/9168878743#step:6:864