Conversation
ggerganov
approved these changes
Oct 10, 2025
Member
Author
|
Seems this introduces a memory leak: |
Member
Author
|
@ochafik Mind having a look at this? |
Member
Author
|
@ochafik gentle ping |
This was referenced Oct 29, 2025
Collaborator
|
@CISC thanks for flagging, should now be fixed (in my fork; will push all my future updates since I no longer have contributor access to the google repo) Please sync from https://github.com/ochafik/minja/blob/main/include/minja/minja.hpp :-) |
ochafik
approved these changes
Oct 29, 2025
Member
Author
|
@ochafik Thanks for fixing! |
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* sync minja.hpp Adds Call/EndCall support, used in MiniCPM3 and MiniCPM4-MCP. * remove spurious semicolon * sync from ochafik/minja
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* sync minja.hpp Adds Call/EndCall support, used in MiniCPM3 and MiniCPM4-MCP. * remove spurious semicolon * sync from ochafik/minja
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* sync minja.hpp Adds Call/EndCall support, used in MiniCPM3 and MiniCPM4-MCP. * remove spurious semicolon * sync from ochafik/minja
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with latest
minja. Adds Call/EndCall support, used inMiniCPM3andMiniCPM4-MCP.Might need additional support for actually parsing the tool calls.