[bug fix] initialise buffer.device in ggml_hexagon_session#16816
Merged
max-krasnyansky merged 1 commit intoggml-org:masterfrom Oct 28, 2025
Merged
[bug fix] initialise buffer.device in ggml_hexagon_session#16816max-krasnyansky merged 1 commit intoggml-org:masterfrom
max-krasnyansky merged 1 commit intoggml-org:masterfrom
Conversation
github-actions
Bot
added
the
ggml
max-krasnyansky
approved these changes
Oct 28, 2025
Member
max-krasnyansky
left a comment
max-krasnyansky
left a comment
There was a problem hiding this comment.
Yep. Good catch. I'm thinking "how did I miss this?" :)
ggml_backend_buft_get_device() uses that .device pointer.
I merge locally and tested on Gen5 device.
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems
buffer_type.deviceandrepack_buffer_type.deviceremains uninitialised.This causes an sporadic crash at
ggml_backend_dev_get_props(dev, &props);atllama-model.cpp:6184.I believe
ggml_hexagon_sessionshould always be initialised with the device it corresponds to?The original code works fine when ran via the cli, however, the crash becomes apparent when bundled into a consumer facing APK.
This fix is tested to fix this issue (running from packaged APK, S25+ Ultra)