CUDA: fuse rope + set_rows#16884
Merged
am17an merged 5 commits intoggml-org:masterfrom Nov 13, 2025
Merged
Conversation
am17an
commented
Oct 31, 2025
am17an
commented
Oct 31, 2025
406c867 to
dc814b8
Compare
ORippler
reviewed
Oct 31, 2025
Collaborator
ORippler
left a comment
There was a problem hiding this comment.
While the fusion itself is quite simple, I would still recommend to add a test to test-backend-ops for it nonetheless
Contributor
Author
There is already a test added in the vulkan PR #16769 |
89faa24 to
6762493
Compare
JohannesGaessler
approved these changes
Nov 12, 2025
Contributor
|
I forgot: this is the performance I measured. The reordering of the ggml graph seems to be very slightly slower in some cases but as this is difficult to generalize I think it's fine.
|
Contributor
Author
|
Ok just to be sure I ran PPL tests with and without this PR and they look all good with/without |
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* CUDA: add fused rope * move k forward_expand up * create helper function instead of re-using params * make assert statement more in line with comment * rope_norm: coalesced writes to global mem
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* CUDA: add fused rope * move k forward_expand up * create helper function instead of re-using params * make assert statement more in line with comment * rope_norm: coalesced writes to global mem
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* CUDA: add fused rope * move k forward_expand up * create helper function instead of re-using params * make assert statement more in line with comment * rope_norm: coalesced writes to global mem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #16769.
On a 4090: