opencl: fix rms_norm_mul#17250
Merged
max-krasnyansky merged 2 commits intoggml-org:masterfrom Nov 16, 2025
Merged
Conversation
github-actions
Bot
added
ggml
max-krasnyansky
approved these changes
Nov 16, 2025
Member
max-krasnyansky
left a comment
max-krasnyansky
left a comment
There was a problem hiding this comment.
@lhez would be good to remove the commented-out code in the next round of updates
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* opencl: use subgrroup reduce for reduction in rms_norm_mul * opencl: add comment about workgroup size
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* opencl: use subgrroup reduce for reduction in rms_norm_mul * opencl: add comment about workgroup size
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* opencl: use subgrroup reduce for reduction in rms_norm_mul * opencl: add comment about workgroup size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rms_norm_mul kernel produces incorrect result when ne00 = 768. This PR changes how the kernel does reduction to get the sum. This seems to fix the issue.