tests: Avoid floating point precision false positives in SUM#17471
Merged
jeffbolznv merged 2 commits intoggml-org:masterfrom Dec 20, 2025
Merged
tests: Avoid floating point precision false positives in SUM#17471jeffbolznv merged 2 commits intoggml-org:masterfrom
jeffbolznv merged 2 commits intoggml-org:masterfrom
Conversation
jeffbolznv
force-pushed
the
sum_false_positives
branch
from
2ec5c53 to
1a4d13d
Compare
Contributor
Author
|
I saw a CI job where the same kind of failure manifested for MEAN, so I've applied the same change there. |
ggerganov
approved these changes
Dec 20, 2025
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
…g#17471) * tests: Avoid floating point precision false positives in SUM * also apply to test_mean
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* tests: Avoid floating point precision false positives in SUM * also apply to test_mean
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…g#17471) * tests: Avoid floating point precision false positives in SUM * also apply to test_mean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17413 (comment)
This was easily reproducible with both Vulkan and CUDA backends by running the tests in a loop, and is a floating point precision issue. With catastrophic cancellation I could even see some very large errors like:
Changing the input distribution to not be centered around zero seems to workaround the issue.