You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I find it a bit confusing though. Does it mean if you warmup with a small image, then using a larger image would fail?
Indeed, the bug was because buf_compute_meta was never allocated if warmup is never called, so it still need to be called at least once.
If the user use a bigger image later on, ggml_backend_sched_alloc_graph inside clip_image_batch_encode will be responsible for allocating a bigger device buffer.
There is also an alternative to fix this issue: to allocate buf_compute_meta upon initializing clip_ctx. But since warmup also does other stuff, like deciding the status of flash attn, log unsupported ops, it should still be called at least once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #17676