cann: refactor ACL graph cache#17752
Merged
hipudding merged 1 commit intoggml-org:masterfrom Dec 24, 2025
Merged
Conversation
Move the graph property checking code into methods of LRU cache. Signed-off-by: Wang Weixuan <wangweixvan@gmail.com>
1 task
Collaborator
|
@TianHao324 , could you help test its actual performance on qwen2.5b–0.5b? |
Contributor
test result: |
Collaborator
|
cc @noemotiovon |
Collaborator
|
@TianHao324, Based on your test results, it appears that ACL Graph was not enabled. Please enable the ACL Graph feature and run the test again. |
Collaborator
cli-test |
Collaborator
parallel test: |
Collaborator
|
@hipudding LGTM, If you have time, feel free to jump in and help out. |
hipudding
approved these changes
Dec 24, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
Move the graph property checking code into methods of LRU cache. Signed-off-by: Wang Weixuan <wangweixvan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CANN backend: This PR refactors the LRU cache responsible for mapping GGML graph properties to CANN graphs. We have reorganized the graph property-related code from the lengthy
ggml-cann.cppfile into dedicated structuresggml_graph_node_properties,ggml_cann_graph, andggml_cann_graph_lru_cache.This change aims to improve code clarity by separating concerns. There are no functional changes. The code has been formatted with clang-format.
CC @noemotiovon