Skip to content

android: fix missing screenshots for Android.md#18156

Merged
ggerganov merged 3 commits intoggml-org:masterfrom
naco-siren:android-doc-fix
Dec 19, 2025
Merged

android: fix missing screenshots for Android.md#18156
ggerganov merged 3 commits intoggml-org:masterfrom
naco-siren:android-doc-fix

Conversation

@naco-siren
Copy link
Copy Markdown
Contributor

@naco-siren naco-siren commented Dec 18, 2025

This PR add the missing screenshot links in doc/android.md, plus a few minor documentation and UI polish.

@naco-siren naco-siren changed the title android: polish documentation, add missing screenshots android: add missing screenshots for Android.md Dec 18, 2025
@github-actions github-actions Bot added documentation Improvements or additions to documentation android Issues specific to Android examples labels Dec 18, 2025
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we host the media files (images, videos) as Github user content to avoid increasing the size of the repository.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ggerganov, that's a great point, here are my amends:

  1. For the production app screenshots, I replaced the blobs with GitHub pages' URLs. No problem at all.
  2. As for the Android Studio screenshot, I compressed the 1.7MB PNG a few times (apologies for force pushes) and now it's less than 500KB JPG.

I'd recommend keeping the Android Studio screenshot because it gives developers a clear understanding of what the project should look like in the IDE, as well as how to check if it is imported & Gradle synced properly.
Please let me know if this sounds good to you. Thanks again!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this btw:
image

@naco-siren naco-siren force-pushed the android-doc-fix branch 2 times, most recently from f3de717 to 3d8b7dd Compare December 18, 2025 17:41
@naco-siren naco-siren requested a review from ggerganov December 18, 2025 18:02
@naco-siren naco-siren changed the title android: add missing screenshots for Android.md android: fix missing screenshots for Android.md Dec 18, 2025
@ggerganov ggerganov merged commit 52fc7fe into ggml-org:master Dec 19, 2025
2 checks passed
@naco-siren naco-siren deleted the android-doc-fix branch December 19, 2025 14:58
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
* Android basic sample app layout polish

* Add missing screenshots and polish android README doc

* Replace file blobs with URLs served by GitHub pages service.
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
* Android basic sample app layout polish

* Add missing screenshots and polish android README doc

* Replace file blobs with URLs served by GitHub pages service.
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* Android basic sample app layout polish

* Add missing screenshots and polish android README doc

* Replace file blobs with URLs served by GitHub pages service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android Issues specific to Android documentation Improvements or additions to documentation examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants