Skip to content

refactor : remove libcurl, use OpenSSL when available#18828

Merged
angt merged 6 commits intoggml-org:masterfrom
angt:refactor-remove-libcurl-use-openssl-when-available
Jan 14, 2026
Merged

refactor : remove libcurl, use OpenSSL when available#18828
angt merged 6 commits intoggml-org:masterfrom
angt:refactor-remove-libcurl-use-openssl-when-available

Conversation

@angt
Copy link
Copy Markdown
Member

@angt angt commented Jan 14, 2026

No description provided.

@angt
refactor : remove libcurl, use OpenSSL when available
1d13ca9 
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
CISC
CISC approved these changes Jan 14, 2026
View reviewed changes
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
angt added 2 commits January 14, 2026 09:36
@angt
Update README.md
cccd16a 
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt
Update copilot-setup-steps
39caa4c 
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@github-actions github-actions Bot added documentation Improvements or additions to documentation build Compilation issues script Script related android Issues specific to Android nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment examples python python script changes devops improvements to build systems and github actions SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Jan 14, 2026
@angt
Enable SSL in all releases
1e6abef 
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
CISC
CISC reviewed Jan 14, 2026
View reviewed changes
Comment thread .github/workflows/release.yml Outdated
@angt
Disable SSL for ios-xcode-build
cd0c229 
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt
Copy link
Copy Markdown
Member Author

angt commented Jan 14, 2026

@CISC we can also enable boringssl in build-linux-cross.yml ?

@CISC
Copy link
Copy Markdown
Member

CISC commented Jan 14, 2026

@CISC we can also enable boringssl in build-linux-cross.yml ?

They all probably have working libssl, so if anything, just remove -DLLAMA_OPENSSL=OFF and install libssl-dev.

@angt
Copy link
Copy Markdown
Member Author

angt commented Jan 14, 2026

@CISC we can also enable boringssl in build-linux-cross.yml ?

They all probably have working libssl, so if anything, just remove -DLLAMA_OPENSSL=OFF and install libssl-dev.

That would be very surprising, they all do cross-building 👀

@CISC
Copy link
Copy Markdown
Member

CISC commented Jan 14, 2026

@CISC we can also enable boringssl in build-linux-cross.yml ?

They all probably have working libssl, so if anything, just remove -DLLAMA_OPENSSL=OFF and install libssl-dev.

That would be very surprising, they all do cross-building 👀

Why? There's cross-built dependencies. Anyway, doesn't matter, just leave them, might as well have test-cases for non-ssl build.

@angt
Copy link
Copy Markdown
Member Author

angt commented Jan 14, 2026

Let's go ?

cc @ggerganov @ngxson

ngxson
ngxson approved these changes Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this make the downloading code much cleaner now 🚀

Comment thread CMakeLists.txt Outdated
Comment thread common/download.cpp
}

#endif // LLAMA_USE_CURL || LLAMA_USE_HTTPLIB
#endif // defined(LLAMA_USE_HTTPLIB)
Copy link
Copy Markdown
Contributor

@ngxson ngxson Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small note here, but we should probably move the #ifdef inside each function, as it make things easier to follow.

(this should be a follow-up PR)

@angt @ngxson
Update CMakeLists.txt
01965f6 
Co-authored-by: Xuan-Son Nguyen <thichthat@gmail.com>
@angt angt merged commit 516a4ca into ggml-org:master Jan 14, 2026
79 of 80 checks passed
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jan 14, 2026
@Nexesenex
Revert "refactor : remove libcurl, use OpenSSL when available (ggml-o…
67dae70 
…rg#18828)"

This reverts commit 516a4ca.
dillon-blake pushed a commit to Boxed-Logic/llama.cpp that referenced this pull request Jan 15, 2026
@angt @dillon-blake
refactor : remove libcurl, use OpenSSL when available (ggml-org#18828)
8528016
EZForever added a commit to EZForever/llama.cpp-builds that referenced this pull request Jan 15, 2026
@EZForever
Remove curl references following ggml-org/llama.cpp#18828
185d07d
EZForever added a commit to EZForever/llama.cpp-static that referenced this pull request Jan 15, 2026
@EZForever
Remove curl references following ggml-org/llama.cpp#18828
df21565
@taronaeo taronaeo mentioned this pull request Jan 15, 2026
Merged
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jan 15, 2026
@Nexesenex
Revert "refactor : remove libcurl, use OpenSSL when available (ggml-o…
1c6720c 
…rg#18828)"

This reverts commit 516a4ca.
@daeho-ro daeho-ro mentioned this pull request Jan 16, 2026
Merged
6 tasks
@timwalls
Copy link
Copy Markdown

timwalls commented Jan 20, 2026

This will be why my CI/CD built versions of llama-server started failing at runtime with "`https' scheme is not supported" then... :-)

For the next person scratching their head: libssl-dev is now a build dependency, without which the build won't fail but model downloads will stop working.

@angt angt mentioned this pull request Jan 21, 2026
Merged
@angt
Copy link
Copy Markdown
Member Author

angt commented Jan 21, 2026

Thanks @timwalls.
I agree that the message provided by cpp-httplib is not helpful enough in our case.
I've opened a small PR to improve it.

@loci-dev loci-dev mentioned this pull request Jan 21, 2026
Open
@HDembinski HDembinski mentioned this pull request Feb 2, 2026
Closed
@m0nsky m0nsky mentioned this pull request Feb 16, 2026
Merged
@tesurijp tesurijp mentioned this pull request Mar 3, 2026
Closed
MaheshJakkala pushed a commit to MaheshJakkala/llama.cpp that referenced this pull request Mar 15, 2026
@angt @MaheshJakkala
refactor : remove libcurl, use OpenSSL when available (ggml-org#18828)
47b7759
HyperFoldUK pushed a commit to HyperFoldUK/llama.cpp that referenced this pull request Apr 8, 2026
docker : fix vulkan python3.13-dev and s390x build deps
e2056d1 
Two Dockerfile fixes:

1. vulkan.Dockerfile: replace apt-based python3.13/python3.13-dev
   install with uv (Astral Python manager). Ubuntu 26.04 ('resolute')
   does not ship python3.13-dev as a separate apt package, causing the
   'full' stage to fail with exit code 100 ('Unable to locate package
   python3.13-dev'). Using uv to install Python 3.13 independently of
   the system package manager resolves this.

   Also switches build-stage SSL dep from libcurl4-openssl-dev to
   libssl-dev, consistent with upstream refactor (ggml-org#18828).

2. s390x.Dockerfile: replace libcurl4-openssl-dev with libssl-dev in
   the build stage, matching upstream refactor (ggml-org#18828).

Fixes: vulkan linux/amd64 'full' stage failing with exit code 100
Refs: ggml-org#20530, ggml-org#18828
HyperFoldUK pushed a commit to HyperFoldUK/llama.cpp that referenced this pull request Apr 8, 2026
docker : fix vulkan python3.13-dev and s390x build deps
a2cc355 
Two Dockerfile fixes:

1. vulkan.Dockerfile: replace apt-based python3.13/python3.13-dev
   install with uv (Astral Python manager). Ubuntu 26.04 ('resolute')
   does not ship python3.13-dev as a separate apt package, causing the
   'full' stage to fail with exit code 100 ('Unable to locate package
   python3.13-dev'). Using uv to install Python 3.13 independently of
   the system package manager resolves this.

   Also switches build-stage SSL dep from libcurl4-openssl-dev to
   libssl-dev, consistent with upstream refactor (ggml-org#18828).

2. s390x.Dockerfile: replace libcurl4-openssl-dev with libssl-dev in
   the build stage, matching upstream refactor (ggml-org#18828).

Fixes: vulkan linux/amd64 full stage failing with exit code 100
Refs: ggml-org#20530, ggml-org#18828
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
@angt
refactor : remove libcurl, use OpenSSL when available (ggml-org#18828)
86260cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

@ggerganov ggerganov ggerganov approved these changes

@ngxson ngxson ngxson approved these changes

@danbev danbev Awaiting requested review from danbev danbev is a code owner

Assignees

No one assigned

Labels

android Issues specific to Android build Compilation issues devops improvements to build systems and github actions documentation Improvements or additions to documentation examples nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment python python script changes script Script related SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@angt @CISC @timwalls @ggerganov @ngxson