server: do not log certain endpoints (avoid log spam)#19028
server: do not log certain endpoints (avoid log spam)#19028ngxson merged 1 commit intoggml-org:masterfrom
Conversation
CISC
left a comment
CISC
left a comment
There was a problem hiding this comment.
Would it make sense to at least add a SRV_DBG so you can see the requests being made when debug is enabled?
|
In my experience, I haven't found any occasions where I find these lines (and the request logging in general) helpful. Mostly because this function only log a request when it's already finished. Probably I will remove this or refactor into something more useful (i.e. log before the request is processed) |
|
@ngxson How about the |
| if (req.path == "/health" | ||
| || req.path == "/v1/health" | ||
| || req.path == "/models" | ||
| || req.path == "/v1/models" | ||
| || req.path == "/props" | ||
| || req.path == "/metrics" |
There was a problem hiding this comment.
@aviallon should be skipped too, but I think we will get rid of this logic soon
There was a problem hiding this comment.
By the way, I saw you work a lot on the HTTP code recently.
By chance, did you fix the /health requests starvation when the server is overloaded?
3 participants
Avoid spamming the log with requests on
/healthor/modelsAPI