Skip to content

cli : load parser definition#19031

Merged
aldehir merged 2 commits intoggml-org:masterfrom
aldehir:cli-fix-parser
Jan 23, 2026
Merged

cli : load parser definition#19031
aldehir merged 2 commits intoggml-org:masterfrom
aldehir:cli-fix-parser

Conversation

@aldehir
Copy link
Copy Markdown
Contributor

@aldehir aldehir commented Jan 22, 2026

fix #19018

@ngxson I would like to refactor the common interface eventually to avoid serializing the definition. For now, we have to deserialize the PEG parser definition because the server passes params through a nholmann::json object.

Copy link
Copy Markdown
Member

@pwilkin pwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it :)

@aldehir aldehir merged commit a3e8128 into ggml-org:master Jan 23, 2026
78 checks passed
ronaldmannak pushed a commit to PicoMLX/llama.cpp that referenced this pull request Jan 24, 2026
* cli : load parser definition

* cont : only unload if a parser is defined
ronaldmannak pushed a commit to PicoMLX/llama.cpp that referenced this pull request Jan 24, 2026
* cli : load parser definition

* cont : only unload if a parser is defined
shaofeiqi pushed a commit to qualcomm/llama.cpp that referenced this pull request Feb 6, 2026
* cli : load parser definition

* cont : only unload if a parser is defined
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* cli : load parser definition

* cont : only unload if a parser is defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: terminate called after throwing an instance of 'std::runtime_error' what(): Failed to parse due to missing parser definition. Aborted

3 participants