Skip to content

ggml : avoid UB in gemm ukernel + tests#19642

Merged
ggerganov merged 1 commit intomasterfrom
gg/ggml-fa-cpu-fix-ub
Feb 15, 2026
Merged

ggml : avoid UB in gemm ukernel + tests#19642
ggerganov merged 1 commit intomasterfrom
gg/ggml-fa-cpu-fix-ub

Conversation

@ggerganov
Copy link
Copy Markdown
Member

cont #19422

  • Reword the GEMM ukernel to not trip the compiler's aggressive loop optimization warnings. It's better to avoid the global pragma as it might be useful for other static analysis
  • Add test-backend-ops with BS=75 to exercise the new tiled SIMD implementation

@ggerganov ggerganov requested a review from am17an February 15, 2026 10:32
@github-actions github-actions Bot added testing Everything test related ggml changes relating to the ggml tensor library for machine learning labels Feb 15, 2026
Copy link
Copy Markdown
Contributor

@am17an am17an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! AFAIK the compiler warning was only tripping up the AMX backend, not sure why. But this PR is anyways more readable

@ggerganov
Copy link
Copy Markdown
Member Author

Yes these warnings maybe depend on the gcc version.

@ggerganov ggerganov merged commit 08e6d91 into master Feb 15, 2026
76 of 78 checks passed
@ggerganov ggerganov deleted the gg/ggml-fa-cpu-fix-ub branch February 15, 2026 12:56
liparetejas pushed a commit to liparetejas/llama.cpp that referenced this pull request Feb 23, 2026
bartowski1182 pushed a commit to bartowski1182/llama.cpp that referenced this pull request Mar 2, 2026
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request Mar 3, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants