Skip to content

Add gfx950 target for ROCm 7.2#19834

Open
superm1 wants to merge 2 commits intoggml-org:masterfrom
superm1:gfx-950
Open

Add gfx950 target for ROCm 7.2#19834
superm1 wants to merge 2 commits intoggml-org:masterfrom
superm1:gfx-950

Conversation

@superm1
Copy link
Copy Markdown
Contributor

@superm1 superm1 commented Feb 23, 2026

AMD's binary builds do include GFX950.

CC @IMbackK , @slojosic-amd, @hammmmy

AMD's binary builds do include GFX950.
@superm1 superm1 requested review from CISC and ngxson as code owners February 23, 2026 15:46
@superm1
Copy link
Copy Markdown
Contributor Author

superm1 commented Feb 23, 2026

@IMbackK
Copy link
Copy Markdown
Collaborator

IMbackK commented Feb 23, 2026

gfx950 is not supported.

it will match

#define GGML_CUDA_CC_IS_CDNA3(cc) (cc >= GGML_CUDA_CC_CDNA3 && cc < GGML_CUDA_CC_RDNA1)
but not
#if defined(CDNA3) || defined(CDNA2) || defined(CDNA1)
which will cause the host and device code to get out of sync.

Unfortunately the hip compiler dose not provide a better solution to detect it on the device side at compile time other than to add every device family.

Someone with access to gfx950 hardware will have to add it, then test, and ideally also tune the parameters these macros are for first.

@IMbackK IMbackK closed this Feb 23, 2026
@superm1
Copy link
Copy Markdown
Contributor Author

superm1 commented Feb 23, 2026

@slojosic-amd can you help?

@github-actions github-actions Bot added the devops improvements to build systems and github actions label Feb 23, 2026
@IMbackK IMbackK reopened this Apr 9, 2026
@IMbackK IMbackK requested a review from a team as a code owner April 9, 2026 19:59
Copy link
Copy Markdown
Member

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not built by any other CI I'd like to see a fresh successful run please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants