ggml : fix AMX and improve alignment checks#19867
Closed
angt wants to merge 1 commit intoggml-org:masterfrom
Closed
ggml : fix AMX and improve alignment checks#19867angt wants to merge 1 commit intoggml-org:masterfrom
angt wants to merge 1 commit intoggml-org:masterfrom
Conversation
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Member
Author
|
I use from #16315 |
Member
|
Does this fix the issues with LFM2.5 reported in #19184? |
Member
Author
Member
|
I think this PR fixes the performance regression for the AMX backend which I reported in #19039. Here are some benchmarks on a C4 instance with 16 vCPUs running in the Google Cloud (using 8 threads):
|
Member
|
Hm, when running Full log below. Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the selector was too restrictive and some models fell back to
CPU_REPACK:
Now they use AMX directly: