Skip to content

Fix compile bug#20203

Merged
pwilkin merged 2 commits intoggml-org:masterfrom
pwilkin:fix-compile-autoparser
Mar 8, 2026
Merged

Fix compile bug#20203
pwilkin merged 2 commits intoggml-org:masterfrom
pwilkin:fix-compile-autoparser

Conversation

@pwilkin
Copy link
Copy Markdown
Member

@pwilkin pwilkin commented Mar 7, 2026

Fixes #20187

@pwilkin pwilkin requested review from ggerganov and ngxson as code owners March 7, 2026 18:20
@pwilkin pwilkin force-pushed the fix-compile-autoparser branch from 9602d69 to fb96755 Compare March 7, 2026 18:20
@pwilkin pwilkin requested a review from CISC March 7, 2026 21:46
Copy link
Copy Markdown
Member

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a compile bug, you were modifying the input, which was the point, but that doesn't work with the C++20 implementation of accumulate.

Comment thread common/chat-auto-parser-helpers.cpp Outdated
@rwmjones
Copy link
Copy Markdown

rwmjones commented Mar 8, 2026

I tested this and it fixes the build problem with GCC 16 (#20187). Thanks.

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
@pwilkin pwilkin merged commit 9b24886 into ggml-org:master Mar 8, 2026
69 of 78 checks passed
bartowski1182 pushed a commit to bartowski1182/llama.cpp that referenced this pull request Mar 10, 2026
* Fix compile bug

* Update common/chat-auto-parser-helpers.cpp

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Ethan-a2 pushed a commit to Ethan-a2/llama.cpp that referenced this pull request Mar 20, 2026
* Fix compile bug

* Update common/chat-auto-parser-helpers.cpp

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* Fix compile bug

* Update common/chat-auto-parser-helpers.cpp

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
* Fix compile bug

* Update common/chat-auto-parser-helpers.cpp

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile bug: 'error: cannot bind non-const lvalue reference' possibly because of GCC 16

3 participants