server : correct index on finish in OAI completion streams#20226
Merged
ngxson merged 1 commit intoggml-org:masterfrom Mar 8, 2026
Merged
server : correct index on finish in OAI completion streams#20226ngxson merged 1 commit intoggml-org:masterfrom
ngxson merged 1 commit intoggml-org:masterfrom
Conversation
ggerganov
approved these changes
Mar 8, 2026
ngxson
approved these changes
Mar 8, 2026
Member
|
@decahedron1 Thanks for the fix. If you would like to contribute more, adding a basic server test to https://github.com/ggml-org/llama.cpp/blob/master/tools/server/tests/unit/test_chat_completion.py would be appreciated. It can send a chat completion request with stream = true and n > 1 and assert that the n indices are observed in the responses. |
bartowski1182
pushed a commit
to bartowski1182/llama.cpp
that referenced
this pull request
Mar 10, 2026
Ethan-a2
pushed a commit
to Ethan-a2/llama.cpp
that referenced
this pull request
Mar 20, 2026
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
rsenthilkumar6
pushed a commit
to rsenthilkumar6/llama.cpp
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
/v1/chat/completionswith"stream": trueand annvalue greater than 1, the stop message would always have itsindexset to0instead of the correct index, making it impossible to tell which stream actually finished.