PEG parser for LFM2#20251
Conversation
|
🤔 surprisingly @pwilkin, this hasn't actually fixed the issue with LFM2.5-Instruct. Do I need to add a cli flag to force the use of the PEG parser instead of the autoparser? edit: testing against Not sure if this is irrelevant or if it indicates that the code in this PR is not being invoked properly, but I still get the following on boot: And the following verbose logs from the middle of the request, right as the tool call is completed: Logs |
|
I think it's because the template doesn't include the markers this code uses to detect if it's LFM-2.5. In fact, I'm not seeing much that can be used as a discriminator. |
|
It was working properly pre-auto parser; what was used to discriminate in that code? |
|
Looks like it's the same tags. But LFM2.5 doesn't appear to use these tags, which means it must have been handled by the previous generic parser. |
* PEG parser for LFM2 * Simplify using python_value()
* PEG parser for LFM2 * Simplify using python_value()
|
that change broke the lfm2 tool calling |
* PEG parser for LFM2 * Simplify using python_value()
* PEG parser for LFM2 * Simplify using python_value()
Dedicated parser for LFM2, this is the only model using Python-style tools for now, so I won't integrate it into the autoparser yet until more templates in this style show up.
Fixes #20245