Skip to content

tests: Fix invalid iterator::end() dereference in common_regex#20445

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
rillomas:fix-invalid-iterator-dereference
Mar 16, 2026
Merged

tests: Fix invalid iterator::end() dereference in common_regex#20445
ggerganov merged 1 commit intoggml-org:masterfrom
rillomas:fix-invalid-iterator-dereference

Conversation

@rillomas
Copy link
Copy Markdown
Contributor

@rillomas rillomas commented Mar 12, 2026

When compiling with VS2026 18.4 I noticed test-regex-partial crashes immediately with debug build.

image

I tracked this down to an iterator::end() dereference in the following test case which was occurring here.

    assert_equals<std::string>(
        "^(a*)",
        regex_to_reversed_partial_regex("a*"));

This fix adds bounds checking to prevent such dereferencing.

@rillomas rillomas marked this pull request as ready for review March 12, 2026 08:28
@rillomas rillomas changed the title regex: Fix invalid iterator::end() dereference common: Fix invalid iterator::end() dereference in common_regex Mar 12, 2026
@rillomas rillomas changed the title common: Fix invalid iterator::end() dereference in common_regex tests: Fix invalid iterator::end() dereference in common_regex Mar 13, 2026
@rillomas
Copy link
Copy Markdown
Contributor Author

rillomas commented Mar 13, 2026

Hi @ggerganov, @CISC can you have a look at this (or assign someone sufficient)? Thanks

@aldehir
Copy link
Copy Markdown
Contributor

aldehir commented Mar 16, 2026

I believe we have eliminated most, if not all, uses of the partial regex implementation.

Still, I reproduced this and the fix works. Thanks!

@ggerganov ggerganov merged commit d393649 into ggml-org:master Mar 16, 2026
69 of 79 checks passed
@rillomas rillomas deleted the fix-invalid-iterator-dereference branch March 16, 2026 07:18
Ethan-a2 pushed a commit to Ethan-a2/llama.cpp that referenced this pull request Mar 20, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants