Models: Add control vector functions to models that missed it (initially meant for qwen3.5 and qwen-next models)#20653
Merged
CISC merged 6 commits intoggml-org:masterfrom Mar 18, 2026
Conversation
CISC
approved these changes
Mar 16, 2026
Member
CISC
left a comment
CISC
left a comment
There was a problem hiding this comment.
Thank you, this was accidentally left out!
Would you mind checking the other models as well? I think there are a couple also missing this...
Contributor
Author
|
I cannot test them all but I'll go through them tomorrow and add it to the missing ones. |
Contributor
Author
|
I updated the rest of the models. Chatglm, jais and lfm2 are slightly different than the rest. So it would be great if you could have a look at those in particular. To my understanding it should be correct like that. |
CISC
approved these changes
Mar 18, 2026
Member
CISC
left a comment
CISC
left a comment
There was a problem hiding this comment.
Thank you, perfect. :)
I'm not sure the embedding models should have it, and I don't think it's correct in plamo2, so best leave them out for now...
GreyWorks
changed the title
Ethan-a2
pushed a commit
to Ethan-a2/llama.cpp
that referenced
this pull request
Mar 20, 2026
* Add control vector functions to qwen3.5 and qwen-next models * Add missing cvec compatibility to the rest of the models * Adjust comments and formatting * cleanup * whitespace --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
nisparks
added a commit
to nisparks/llama.cpp
that referenced
this pull request
Apr 4, 2026
PR ggml-org#20653 added control vector support to models that were missing it, but the plamo2 change was incomplete — it added the comment ('// input for next layer') but missed the actual build_cvec() call. Compare the ggml-org#20653 diffs for the two sibling models: plamo3.cpp: +build_cvec(cur, il) +cb(cur, "l_out", il) +// input for next layer plamo2.cpp: +// input for next layer (build_cvec omitted) Without this call, --control-vector is silently ignored on PLaMo-2. Normal inference is unaffected since build_cvec is a no-op when no control vector is loaded. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* Add control vector functions to qwen3.5 and qwen-next models * Add missing cvec compatibility to the rest of the models * Adjust comments and formatting * cleanup * whitespace --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
rsenthilkumar6
pushed a commit
to rsenthilkumar6/llama.cpp
that referenced
this pull request
May 1, 2026
* Add control vector functions to qwen3.5 and qwen-next models * Add missing cvec compatibility to the rest of the models * Adjust comments and formatting * cleanup * whitespace --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds control vector support to Qwen3.5, Qwen3.5-MoE and Qwen3-next (Qwen3-coder-next).
It was missing before but was present for Qwen3-vl and so on.
Control vector PR for reference: #5970
The PR resolves #20541
AI disclaimer: I had Claude point me at the missing parts and help me understand the correct position for the two lines added in each file.
I tested the changes myself and made sure it doesn't break things where I could. The local CI pipeline shows no problem with the new code.