server: use httplib dynamic threads#20817
Merged
ngxson merged 2 commits intoggml-org:masterfrom Mar 23, 2026
Merged
Conversation
rgerganov
approved these changes
Mar 23, 2026
Member
rgerganov
left a comment
rgerganov
left a comment
There was a problem hiding this comment.
This seems to work well and while it's not the ideal solution, I think it is good enough for all practical purposes. Thanks!
rgerganov
reviewed
Mar 23, 2026
| // spawn n_threads_http fixed thread (always alive), while allow up to 1024 max possible number of threads | ||
| // when n_threads_http is used, server will create new "dynamic" threads that will be destroyed after processing each request | ||
| // ref: https://github.com/yhirose/cpp-httplib/pull/2368 | ||
| return new httplib::ThreadPool(n_threads_http, 1024); |
Member
There was a problem hiding this comment.
just in case, let's use std::max(1024, n_threads_http) to support more than 1024:
return new httplib::ThreadPool(n_threads_http, std::max(1024, n_threads_http));
Contributor
Author
There was a problem hiding this comment.
good catch, I changed the logic to n_threads_http + 1024 instead. if n_threads_http is high because of n_parallel = 2000 for example, then we always have 1024 for overhead connections
rgerganov
approved these changes
Mar 23, 2026
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* server: use httplib dynamic threads * change to n_threads_http + 1024
rsenthilkumar6
pushed a commit
to rsenthilkumar6/llama.cpp
that referenced
this pull request
May 1, 2026
* server: use httplib dynamic threads * change to n_threads_http + 1024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #20799
Fix #20684
Server can now create up to maximum of 1024 threads on demand. Dynamic threads will be terminated once they finish their task.