Skip to content

contrib: add "Requirements" section to PR template#20841

Merged
ngxson merged 3 commits intoggml-org:masterfrom
ngxson:xsn/better_pr_template
Mar 23, 2026
Merged

contrib: add "Requirements" section to PR template#20841
ngxson merged 3 commits intoggml-org:masterfrom
ngxson:xsn/better_pr_template

Conversation

@ngxson
Copy link
Copy Markdown
Contributor

@ngxson ngxson commented Mar 21, 2026

Changes:

  • Requires keeping the acknowledge about contributing guidelines
  • Requires disclosing AI usage
  • Addition guide for AI agents

@ngxson ngxson requested review from a team and ggerganov March 21, 2026 15:18
@github-actions github-actions Bot added the devops improvements to build systems and github actions label Mar 21, 2026
@am17an
Copy link
Copy Markdown
Contributor

am17an commented Mar 21, 2026

Does a commit co-authored with Claude count as disclosure?

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented Mar 21, 2026

Does a commit co-authored with Claude count as disclosure?

I think co-authored doesn't specify exactly which part of the work is done by claude.

I also believe that a written disclosure encourages the contributor to be responsible / be transparent about their work.

@JohannesGaessler
Copy link
Copy Markdown
Contributor

JohannesGaessler commented Mar 21, 2026

How about we make it checkboxes? Something like

  • I have read and understood the contributing guidelines.
  • AI was used to write parts of the code.

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented Mar 21, 2026

@JohannesGaessler I find it a bit inconvenient because the editing screen requires placing an x inside the checkbox [ ]. If github allows having PR template that works like issue template, I think that would make more sense

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented Mar 23, 2026

I think this is pretty much a QoL improvement for both contributors & maintainers, making it clear how to write a PR description

Since this doesn't include any functional or policy changes, could we have it merged soon @ggerganov @ggml-org/maintainers ? Thanks.

@ngxson ngxson merged commit bd69921 into ggml-org:master Mar 23, 2026
2 checks passed
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* contrib: add "Requirements" section to PR template

* typo [no ci]

* use h2, add "Additional information"

---------

Co-authored-by: Piotr Wilkin (ilintar) <piotr.wilkin@syndatis.com>
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
* contrib: add "Requirements" section to PR template

* typo [no ci]

* use h2, add "Additional information"

---------

Co-authored-by: Piotr Wilkin (ilintar) <piotr.wilkin@syndatis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants