Skip to content

common : init in params parser, add Windows UTF-8 support#21176

Merged
angt merged 1 commit intoggml-org:masterfrom
angt:common-init-in-params-parser-add-windows-utf-8-support
Mar 31, 2026
Merged

common : init in params parser, add Windows UTF-8 support#21176
angt merged 1 commit intoggml-org:masterfrom
angt:common-init-in-params-parser-add-windows-utf-8-support

Conversation

@angt
Copy link
Copy Markdown
Member

@angt angt commented Mar 30, 2026

Overview

Simplify the common init process and fix windows logging

Additional information

We already call common_params_parse() first, then common_init(), so this adjusts the code to call common_init() first (directly from common_params_parse).

The build info is now only for debug, so we avoid the duplicate with --version.

The UTF-8 setup at the beginning is needed to avoid logging garbage on Windows.

Requirements

@angt
Copy link
Copy Markdown
Member Author

angt commented Mar 30, 2026

On windows, without the patch:

PS Z:\>  C:\Users\angt\installama\server.exe -hf angt/modelutf8
common_download_file_single_online: no previous model file found C:\Users\angt\AppData\Local\llama.cpp\angt_modelutf8_preset.ini
common_download_file_single_online: HEAD failed, status: 404
no remote preset found, skipping
common_download_file_single_online: no previous model file found C:\Users\angt\.cache\huggingface\hub\models--angt--modelutf8\blobs\bd258782e35f7f458f8aced1adc053e6e92e89bc735ba3be89d38a06121dc517
common_download_file_single_online: downloading from https://huggingface.co/angt/modelutf8/resolve/85ca32e076fd0d1f3817a2cbc78cb34ebae46459/Mödèle_🚀_测试_اختبار_Тест-Q4_K_M.gguf to 

@github-actions github-actions Bot added testing Everything test related examples server labels Mar 30, 2026
Comment thread common/arg.cpp Outdated
The build info is now only for debug, so we avoid the duplicate
with `--version`.

The UTF-8 setup at the beginning is needed to avoid logging
garbage on Windows.

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt angt force-pushed the common-init-in-params-parser-add-windows-utf-8-support branch from 7e6641f to 06aed16 Compare March 30, 2026 11:32
@angt angt merged commit 41361c8 into ggml-org:master Mar 31, 2026
44 of 45 checks passed
slartibardfast pushed a commit to slartibardfast/llama.cpp that referenced this pull request Apr 12, 2026
…1176)

The build info is now only for debug, so we avoid the duplicate
with `--version`.

The UTF-8 setup at the beginning is needed to avoid logging
garbage on Windows.

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
…1176)

The build info is now only for debug, so we avoid the duplicate
with `--version`.

The UTF-8 setup at the beginning is needed to avoid logging
garbage on Windows.

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
…1176)

The build info is now only for debug, so we avoid the duplicate
with `--version`.

The UTF-8 setup at the beginning is needed to avoid logging
garbage on Windows.

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples server testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants