metal: Add FP32 and FP16 support for ADD1 kernel#21267
Closed
Sou-ly wants to merge 3 commits intoggml-org:masterfrom
Closed
metal: Add FP32 and FP16 support for ADD1 kernel#21267Sou-ly wants to merge 3 commits intoggml-org:masterfrom
Sou-ly wants to merge 3 commits intoggml-org:masterfrom
Conversation
4 tasks
Sou-ly
changed the title
Sou-ly
force-pushed
the
metal-implement-missing-add1-op
branch
from
037bd3a to
4137189
Compare
github-actions
Bot
added
testing
Sou-ly
requested review from
a team,
CISC,
JohannesGaessler,
ngxson and
pwilkin
as code owners
Member
|
Bad rebase btw |
Sou-ly
force-pushed
the
metal-implement-missing-add1-op
branch
from
7df6c3e to
4e8de74
Compare
Member
|
Closing as ADD1 is deprecated. Ref: #21363 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add support for the ADD1 operation on the Metal backend.
Supports FP32/FP16.
Additional information
Feature Request: Implement missing ops from backends #14909
Requirements
YES: to quickly implement the fp16 version through redundant checks and templates implementation (second commit).