llama-quant : remove these checks as some arches do not have these tensors#21544
Closed
ownia wants to merge 1 commit intoggml-org:masterfrom
Closed
llama-quant : remove these checks as some arches do not have these tensors#21544ownia wants to merge 1 commit intoggml-org:masterfrom
ownia wants to merge 1 commit intoggml-org:masterfrom
Conversation
…nsors Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
|
Hi @ownia, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
| // | ||
|
|
||
| static bool tensor_allows_quantization(const llama_model_quantize_params * params, llm_arch arch, const ggml_tensor * tensor) { | ||
| static bool tensor_allows_quantization(const llama_model_quantize_params * params, [[maybe_unused]] llm_arch arch, const ggml_tensor * tensor) { |
Contributor
There was a problem hiding this comment.
Wouldn't it make more sense to just remove the argument?
Contributor
Author
There was a problem hiding this comment.
Yes it makes sense. However, I've just noticed that you submitted the PR #21531, perhaps we could drop my PR if yours can be merged?
Contributor
There was a problem hiding this comment.
I would also be fine with closing this PR if mine is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extend #21219.
Additional information
Requirements