Skip to content

Convert: Fix NemotronH Config Parsing#21664

Merged
ggerganov merged 2 commits intoggml-org:masterfrom
anavp-nvidia:fix-nemotron-h-config-parsing
Apr 16, 2026
Merged

Convert: Fix NemotronH Config Parsing#21664
ggerganov merged 2 commits intoggml-org:masterfrom
anavp-nvidia:fix-nemotron-h-config-parsing

Conversation

@anavp-nvidia
Copy link
Copy Markdown
Contributor

Overview

Fixing NVIDIA-Nemotron-3-Nano-4B-BF16 conversion failure due to config parsing issue (KeyError: '-') with latest versions of transformers (5.5.0 and 5.5.1 at least) .

The fix overrides set_vocab in NemotronHModel with a self-contained implementation that uses trust_remote_code=True. This allows the model's own config class to be loaded, which correctly handles the pattern.

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes, AI tools were used to validate the changes.

@anavp-nvidia anavp-nvidia requested a review from CISC as a code owner April 9, 2026 08:51
@ggerganov
Copy link
Copy Markdown
Member

cc @richarddd @michaelw9999

@github-actions github-actions Bot added the python python script changes label Apr 9, 2026
@ggerganov ggerganov requested a review from danbev April 16, 2026 06:30
@ggerganov ggerganov added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Apr 16, 2026
@ggerganov ggerganov merged commit 03b3d07 into ggml-org:master Apr 16, 2026
6 checks passed
@CISC
Copy link
Copy Markdown
Member

CISC commented Apr 16, 2026

cnsiva pushed a commit to saas-home/llama.cpp that referenced this pull request Apr 17, 2026
* fix NemotronH vocab loading by using trust_remote_code for unsupported config patterns

* fix NemotronH tokenizer loading by overriding set_vocab with trust_remote_code
samuraieng pushed a commit to samuraieng/llama.cpp that referenced this pull request Apr 19, 2026
* fix NemotronH vocab loading by using trust_remote_code for unsupported config patterns

* fix NemotronH tokenizer loading by overriding set_vocab with trust_remote_code
mengqin pushed a commit to mengqin/llama.cpp that referenced this pull request Apr 20, 2026
* fix NemotronH vocab loading by using trust_remote_code for unsupported config patterns

* fix NemotronH tokenizer loading by overriding set_vocab with trust_remote_code
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request Apr 21, 2026
* fix NemotronH vocab loading by using trust_remote_code for unsupported config patterns

* fix NemotronH tokenizer loading by overriding set_vocab with trust_remote_code
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Apr 23, 2026
* fix NemotronH vocab loading by using trust_remote_code for unsupported config patterns

* fix NemotronH tokenizer loading by overriding set_vocab with trust_remote_code
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
* fix NemotronH vocab loading by using trust_remote_code for unsupported config patterns

* fix NemotronH tokenizer loading by overriding set_vocab with trust_remote_code
jimbothigpen pushed a commit to jimbothigpen/frankenturbo2 that referenced this pull request May 2, 2026
* fix NemotronH vocab loading by using trust_remote_code for unsupported config patterns

* fix NemotronH tokenizer loading by overriding set_vocab with trust_remote_code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants