Skip to content

codeowners: add team members#21714

Merged
ggerganov merged 1 commit intomasterfrom
0cc4m/codeowners
Apr 16, 2026
Merged

codeowners: add team members#21714
ggerganov merged 1 commit intomasterfrom
0cc4m/codeowners

Conversation

@0cc4m
Copy link
Copy Markdown
Contributor

@0cc4m 0cc4m commented Apr 10, 2026

This reverts commit cf45437.

Overview

The problem is that Github organization teams are invisible to anyone who is not a member of the organization. This unnecessarily obscures who is responsible for what. We can still use teams manually for pings or review requests.

I manually went through the changes and fixed the cases where something else was edited in the file.

Requirements

@0cc4m 0cc4m requested a review from ggerganov April 10, 2026 07:33
@CISC
Copy link
Copy Markdown
Member

CISC commented Apr 10, 2026

Hmmm, that's a bit silly, it's really useful to have teams automatically assigned for reviews, not to mention not having to update CODEOWNERS whenever a team is updated...

Anyway, we should not revert it back to what it was, but rather expand the teams into its members if we're going to do this.

@0cc4m
Copy link
Copy Markdown
Contributor Author

0cc4m commented Apr 10, 2026

We can do that, I wasn't sure which changes were only due to teams. Maybe it's possible to keep the team + the maintainer members of it in the file?

@CISC
Copy link
Copy Markdown
Member

CISC commented Apr 10, 2026

We can do that, I wasn't sure which changes were only due to teams. Maybe it's possible to keep the team + the maintainer members of it in the file?

Perhaps a compromise; keep the teams, but add one main responsible member? If that works...

@am17an
Copy link
Copy Markdown
Contributor

am17an commented Apr 10, 2026

Can we change visibility of some teams which do code reviews? Like the backend teams

@0cc4m
Copy link
Copy Markdown
Contributor Author

0cc4m commented Apr 10, 2026

They are already set to visible, but sadly that just means "visible within the organization". From the outside not much is shown:
image

@ggerganov
Copy link
Copy Markdown
Member

Yes, it's a limitation of Github to not shown the teams outside the organization.

We can add comments in the CODEOWNERS file that mirrors the team members. F.ex.:

# ggml-org/team-abc : member1, member2, ...

@0cc4m 0cc4m force-pushed the 0cc4m/codeowners branch from cb1117d to 5fa979b Compare April 13, 2026 08:47
@0cc4m 0cc4m changed the title codeowners: Revert "codeowners : use teams (#20526)" codeowners: add team members Apr 13, 2026
@0cc4m
Copy link
Copy Markdown
Contributor Author

0cc4m commented Apr 13, 2026

I have added comments as suggested.

@ggerganov ggerganov merged commit b572d1e into master Apr 16, 2026
5 checks passed
@ggerganov ggerganov deleted the 0cc4m/codeowners branch April 16, 2026 10:13
cnsiva pushed a commit to saas-home/llama.cpp that referenced this pull request Apr 17, 2026
samuraieng pushed a commit to samuraieng/llama.cpp that referenced this pull request Apr 19, 2026
mengqin pushed a commit to mengqin/llama.cpp that referenced this pull request Apr 20, 2026
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request Apr 21, 2026
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Apr 23, 2026
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
jimbothigpen pushed a commit to jimbothigpen/frankenturbo2 that referenced this pull request May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants