mtmd: use causal attn for gemma 4 audio (+ small breaking change to mtmd)#21824
Merged
ngxson merged 1 commit intoggml-org:masterfrom Apr 13, 2026
Merged
mtmd: use causal attn for gemma 4 audio (+ small breaking change to mtmd)#21824ngxson merged 1 commit intoggml-org:masterfrom
ngxson merged 1 commit intoggml-org:masterfrom
Conversation
This was referenced Apr 12, 2026
CISC
approved these changes
Apr 13, 2026
danbev
approved these changes
Apr 13, 2026
cnsiva
pushed a commit
to saas-home/llama.cpp
that referenced
this pull request
Apr 13, 2026
HermestoAizales
pushed a commit
to HermestoAizales/llama.cpp
that referenced
this pull request
Apr 13, 2026
ArberSephirotheca
pushed a commit
to ArberSephirotheca/llama.cpp
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Continue #21421
Fix #21820
Fix #21816
For gemma 4, the text model only use non-causal (aka bidirectional attention) for vision input
Breaking change
mtmd_decode_use_non_causalnow requires passing a second param, the currentchunkThe
chunkis optional and can be nullptr (default: assuming the current chunk is image).In the case of gemma 4:
Requirements