cmake: use glob to collect src/models sources#22005
Merged
ngxson merged 2 commits intoggml-org:masterfrom Apr 16, 2026
Merged
Conversation
6 tasks
ggerganov
approved these changes
Apr 16, 2026
CISC
approved these changes
Apr 16, 2026
pwilkin
approved these changes
Apr 16, 2026
|
Just saw this by chance. CMake explicitly discourages GLOB for picking up sources files (see the Note in the file(GLOB) documentation). If you feel you must you might want to at least add Explicit source file listings work like manifests that make builds more reproducible. |
cnsiva
pushed a commit
to saas-home/llama.cpp
that referenced
this pull request
Apr 17, 2026
samuraieng
pushed a commit
to samuraieng/llama.cpp
that referenced
this pull request
Apr 19, 2026
mengqin
pushed a commit
to mengqin/llama.cpp
that referenced
this pull request
Apr 20, 2026
ArberSephirotheca
pushed a commit
to ArberSephirotheca/llama.cpp
that referenced
this pull request
Apr 21, 2026
TheTom
added a commit
to TheTom/llama-cpp-turboquant
that referenced
this pull request
Apr 22, 2026
Cherry-picks ggml-org#22005 — replaces manual model file listing with glob autodiscovery. New model source files are picked up automatically without editing CMakeLists.txt. Co-Authored-By: tturney@psyguard.ai Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TheTom
added a commit
to TheTom/llama-cpp-turboquant
that referenced
this pull request
Apr 22, 2026
Cherry-picks ggml-org#22005 — replaces manual model file listing with glob autodiscovery. New model source files are picked up automatically without editing CMakeLists.txt. Co-Authored-By: tturney@psyguard.ai Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Apr 23, 2026
rsenthilkumar6
pushed a commit
to rsenthilkumar6/llama.cpp
that referenced
this pull request
May 1, 2026
jimbothigpen
pushed a commit
to jimbothigpen/frankenturbo2
that referenced
this pull request
May 2, 2026
Cherry-picks ggml-org#22005 — replaces manual model file listing with glob autodiscovery. New model source files are picked up automatically without editing CMakeLists.txt. Co-Authored-By: tturney@psyguard.ai Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jimbothigpen
pushed a commit
to jimbothigpen/frankenturbo2
that referenced
this pull request
May 2, 2026
Cherry-picks ggml-org#22005 — replaces manual model file listing with glob autodiscovery. New model source files are picked up automatically without editing CMakeLists.txt. Co-Authored-By: tturney@psyguard.ai Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jimbothigpen
pushed a commit
to jimbothigpen/frankenturbo2
that referenced
this pull request
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The goal is to make #22004 a bit easier
Requirements