Additional test for common/gemma4 : handle parsing edge cases#22420
Merged
pwilkin merged 2 commits intoggml-org:masterfrom Apr 27, 2026
Merged
Conversation
pwilkin
approved these changes
Apr 27, 2026
Member
pwilkin
left a comment
pwilkin
left a comment
There was a problem hiding this comment.
More tests are always welcome :)
Contributor
|
Please group them with the other Gemma 4 tests. |
Author
@aldehir done |
aldehir
approved these changes
Apr 27, 2026
Contributor
|
Thanks! |
pwilkin
approved these changes
Apr 27, 2026
IntelNav
pushed a commit
to IntelNav/llama.cpp
that referenced
this pull request
Apr 29, 2026
…rg#22420) * Additional test for common/gemma4 : handle parsing edge cases * Move tests to Gemma 4 test group
IntelNav
pushed a commit
to IntelNav/llama.cpp
that referenced
this pull request
Apr 29, 2026
…rg#22420) * Additional test for common/gemma4 : handle parsing edge cases * Move tests to Gemma 4 test group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add few test cases for #21760
Additional information
Positive and negative tests added for the edge cases fix with using real model file (by analogy with
test_reka_edge_common_pathtest)@aldehir could you take a look and see if tests like these are worth adding for your fix?
Requirements