Skip to content

adds simple grammar parsing tests#2594

Merged
monatis merged 2 commits intoggml-org:masterfrom
drbh:add-grammar-parser-tests
Aug 13, 2023
Merged

adds simple grammar parsing tests#2594
monatis merged 2 commits intoggml-org:masterfrom
drbh:add-grammar-parser-tests

Conversation

@drbh
Copy link
Contributor

@drbh drbh commented Aug 12, 2023

This PR adds simple parsing test to give more insight into the grammar parsing mechanics and expected output.

run tests

mkdir -p build && cd build && cmake ..
cmake --build . --config Release && ./bin/test-grammar-parser

Please let me know if I should make any changes! 🙏

monatis
monatis previously approved these changes Aug 13, 2023
Copy link
Collaborator

@monatis monatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@monatis monatis dismissed their stale review August 13, 2023 08:32

There are failing tests that need to be fixed

@drbh
Copy link
Contributor Author

drbh commented Aug 13, 2023

@monatis should be resolved now. Was missing #include <cassert> header

@monatis monatis merged commit ee77efe into ggml-org:master Aug 13, 2023
@drbh drbh deleted the add-grammar-parser-tests branch August 14, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants