Skip to content

Fixed color reset problem in interactive mode.#283

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
mqy:master
Mar 19, 2023
Merged

Fixed color reset problem in interactive mode.#283
ggerganov merged 1 commit intoggml-org:masterfrom
mqy:master

Conversation

@mqy
Copy link
Copy Markdown
Contributor

@mqy mqy commented Mar 19, 2023

In interactive mode:

Bob: Sure. The largest city in Europe is Moscow, the capital of Russia.
User: xxx

Press CTRL+C, the program exits, but terminal color still remains blue.

To ensure color reset, let's print '\n' in sigint_handler.

bitRAKE added a commit to bitRAKE/llama.cpp that referenced this pull request Mar 19, 2023
@ggerganov ggerganov merged commit 084e2f0 into ggml-org:master Mar 19, 2023
sw pushed a commit that referenced this pull request Mar 19, 2023
* fix coloring of last `n_batch` of prompt, and refactor line input
* forgot the newline that needs to be sent to the model
* (per #283) try to force flush of color reset in SIGINT handler
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
…ml-org#221)

* fix coloring of last `n_batch` of prompt, and refactor line input
* forgot the newline that needs to be sent to the model
* (per ggml-org#283) try to force flush of color reset in SIGINT handler
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* Make fused MoE reproducible

As a bonus, peak performance at pp2048 with u_batch = 2048 is
~8% better.

* Slightly better

* Also do it for non-fused mul_mat_id

---------

Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants