rocm: Automatically build with separate compiler#3244
Closed
danielzgtg wants to merge 1 commit intoggml-org:masterfrom
Closed
rocm: Automatically build with separate compiler#3244danielzgtg wants to merge 1 commit intoggml-org:masterfrom
danielzgtg wants to merge 1 commit intoggml-org:masterfrom
Conversation
A separate CMake project allows setting a separate compiler specifically for ROCm. This also makes the compile config easier eliminating the need for setting the ROCm compiler path. Most importantly, this lets me build llama.cpp with GCC as I get errors while trying to embed this in a Qt application otherwise.
danielzgtg
force-pushed
the
feature/rocmCompiler
branch
from
2b75685 to
e2d3353
Compare
Contributor
Author
|
Superseded by #10256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows and defaults to setting a separate compiler for ROCm.
Before
After
LLAMA_HIPBLASbox incmake-guifor non-Windows. You can still override it withLLAMA_ROCM_PROJECT_CMAKE_ARGSAlternatives
libggml-rocm.so. However, I was unable to get CMake to link it without errors, and I would appreciate any ideas how to.